FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adds a CommonJS build script by jeffkole · Pull Request #23 · instructure-react/react-menu · GitHub

Adds a CommonJS build script - #23

Open
jeffkole wants to merge 2 commits into
instructure-react:masterfrom
joinoneroom:common-js-build
Open

Adds a CommonJS build script#23
jeffkole wants to merge 2 commits into
instructure-react:masterfrom
joinoneroom:common-js-build

Conversation

Copy link
Copy Markdown

This is a start at an attempt to produce a CommonJS build in response to my question yesterday: #22. Let me know what you think.

jeffkole added 2 commits July 14, 2015 14:09
This works for me, because I am pushing these CommonJS builds to my own Github
repo. If we wanted a proper CommonJS distribution, then it would need to be
published to npm.

Copy link
Copy Markdown
Contributor

@jeffkole thanks for this, I like it. I wonder if it wouldn't be better to combine this into a single build and a single release (or at least have a single command for each). i can see a future issue where only globals get built and released (or only the commonjs version).

thoughts?

Copy link
Copy Markdown
Author

One build and release script is definitely better. The current one is fairly specialized (ie, works great with Browserify and if you are including React globally), so I didn't want mess with it, because I do not know the project history. I mostly stole my solution from what I saw from @ryanflorence in rackt/react-router. It is possible that the CommonJS solution can also work just fine for the Browserify case you had targeted originally.

Copy link
Copy Markdown
Contributor

yeah, i think it can. we can ditch the browserify solution if we can make something that will work for:

  • users who are not using a module system
  • users who are using requirejs
  • the new CommonJS build you are proposing

Copy link
Copy Markdown
Author

#26 may fit the bill better.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL