Remove activity_description from Preview admin_activity_log_event schema - #509
Draft
DJK101 wants to merge 1 commit into
Draft
Remove activity_description from Preview admin_activity_log_event schema#509DJK101 wants to merge 1 commit into
DJK101 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
APIs are read by machines — translation belongs in the UI, not in API responses. Drop the localised activity_description property (and its inline example values) from the Preview slice of the activity_log schema. Numbered version slices (2.7 - 2.15) are unchanged and continue to return activity_description. Tracked under intercom/intercom#512356 (parent intercom/intercom#512347). Monolith PR ships in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the activity_description property from the Preview slice of the admin_activity_log_event schema. APIs are read by machines — translation belongs in the UI, not in API responses. Numbered version slices (1.x, 2.x) are unchanged.
Companion PRs
Test plan
Generated with Claude Code