FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add delete company by emilsundberg · Pull Request #340 · intercom/intercom-php · GitHub

/ intercom-php Public

Add delete company - #340

Open
emilsundberg wants to merge 1 commit into
intercom:masterfrom
snowfire:delete-company
ConversationCommits (1)ChecksFiles changed
Open

Add delete company#340
emilsundberg wants to merge 1 commit into
intercom:masterfrom
snowfire:delete-company

Conversation

emilsundberg commented Mar 3, 2021

Copy link
Copy Markdown

Why?

Make it possible to delete a company from Intercom

How?

By making an API request to the company delete endpoint

emilsundberg mentioned this pull request Mar 3, 2021
Open
rahulgdsouza reviewed Jun 14, 2021
View reviewed changes
Comment thread src/IntercomCompanies.php Outdated
rahulgdsouza reviewed Jun 14, 2021
View reviewed changes

rahulgdsouza left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. Can merge once the checks clear.

GabrielAnca reviewed Jun 14, 2021
View reviewed changes

GabrielAnca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking great! I'd complete @rahulgdsouza's comment and add an item to the readme 😄

emilsundberg commented Jun 14, 2021

Copy link
Copy Markdown
Author

I've pushed the changes to adapt to your coding standards. I always try to minimize temporary var usage ;)

rahulgdsouza reviewed Jun 15, 2021
View reviewed changes

rahulgdsouza left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It needs a rebase as it's out-of-date with master. Once that's done I think it's good to go 🚀

emilsundberg force-pushed the delete-company branch 3 times, most recently from 9eb9dec to 285c111 Compare June 19, 2021 18:31

emilsundberg commented Jun 19, 2021

Copy link
Copy Markdown
Author

✓ Rebased

rickintveld commented Oct 30, 2024

Copy link
Copy Markdown

This pull request is open for a while now, is it possible to merge this? I would like to implement this feature

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rahulgdsouza rahulgdsouza left review comments
+2 more reviewers
GabrielAnca GabrielAnca left review comments
rickintveld rickintveld approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL