chore: add PHP 8.5 support and modernize nullable type hints - #232
Open
XternalSoft wants to merge 4 commits into
Open
chore: add PHP 8.5 support and modernize nullable type hints#232XternalSoft wants to merge 4 commits into
XternalSoft wants to merge 4 commits into
Conversation
- Updated GitHub Actions workflow to include PHP 8.3, 8.4, and 8.5 in the test matrix. - Migrated CI to use `shivammathur/setup-php` on Ubuntu 24.04 for better environment management. - Relaxed PHPUnit version constraints in `composer.json` to support versions 9.0 through 11.0. - Refactored various classes to use explicit nullable type hints (`?Type`) for parameters with null default values. - Ensured strict PHP 8.x compatibility by resolving potential deprecation warnings related to implicit nullability.
- Updated `TextHelper::toUtf8` to use an explicit encoding list for `mb_detect_encoding`, ensuring correct handling of non-UTF8 text (e.g., ISO-8859-1). - Applied `#[AllowDynamicProperties]` to `TldParser` to suppress deprecation warnings when setting dynamic configuration properties. - Converted `TldParsingTest::getTestData` to a static method to comply with PHPUnit 10+ requirements. - Verified all 460 tests are passing on PHP 8.5.
- Updated `actions/checkout` from v2 to v4 to resolve Node.js 20 deprecation warnings. - Ensures the CI workflow remains functional on newer GitHub Actions runners.
- Upgraded `actions/checkout` from v4 to v6 to support Node.js 24 natively. - Added `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true` at the workflow level to resolve deprecation warnings for all other actions. - This ensures the CI environment is future-proof and avoids warnings related to Node.js 20 removal.
Copy link
Copy Markdown
|
@XternalSoft Hi! I think the lib is not maintained anymore, would you consider pushing you repo in packagist? It would be very useful! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
I will see... I will let you know |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks a lot for your work! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.