Follow symlink support for readdirp - #5082
Open
mevatron wants to merge 2 commits into
Open
mevatron wants to merge 2 commits into
mevatron wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempt to use native-run on NixOS, and to make packages more reproducible the Nix package manager heavily uses symlinks 😅 Unfortunately, the readdirp method does not follow symlinks by default, and seeing as the @ionic/utils-fs package has many dependent projects, it seemed like making this a non-default option would be the best approach.
I added a WalkerOption followSymlinks and environment variable to also control the behavior IONIC_UTILS_FS_FOLLOW_SYMLINKS.
Would this be something that could be merged in?
Thanks!