fix: restrict installerArgs push to npm client only - #5126
Open
aparajita wants to merge 1 commit into
Open
aparajita wants to merge 1 commit into
aparajita wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Currently, when pnpm is set as the package manager, '--' is inserted before arguments that are meant to be passed on to a script being run. This is incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when pnpm is set as the package manager, '--' is inserted before arguments that are meant to be passed on to a script being run. This is incorrect.
As a result, for example, ionic cap run ios --open --livereload --external, when run with vue/vite, ends up executing pnpm run ionic:serve -- --host=0.0.0.0 --port=8100, and because pnpm does not recognize --, the host and port options are not recognized.