Repository navigation
Support Python 3.14.0rc2, test on CI - #14967
Merged
krassowski merged 13 commits intoAug 26, 2025
Merged
krassowski merged 13 commits into
krassowski merged 13 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
by adding locals to globals
Copy link
Copy Markdown
Member
Author
|
test_eval_formatter failure: FAILED tests/test_text.py::test_eval_formatter - File "<string>", line 1
0[n//i for i in range(1,8)]
^^^
SyntaxError: invalid syntax
is due to this change: python/cpython#21767 It gives [] a semantic meaning so f.format("{[n//i for i in range(1,8)]}", **ns) cannot work without overriding vformat implementation. I am not sure why IPython ships EvalFormatter and what usage is there, and if we should adopt the new upstream behaviour or preserve the old one. It looks like it is exclusively used by ipyparallel and its forks https://github.com/search?q=%22from+IPython.utils.text+import+EvalFormatter%22&type=code |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
We are down to 11 failing tests, some of which are potential jedi upstream issues, some related to debugger: FAILED tests/test_completer.py::TestCompleter::test_all_completions_dups - AssertionError: (True, [])
assert [] == ['TestClass']
Right contains one more item: 'TestClass'
Full diff:
+ []
- [
- 'TestClass',
- ]
FAILED tests/test_completer.py::TestCompleter::test_completion_have_signature - StopIteration
FAILED tests/test_completer.py::TestCompleter::test_deduplicate_completions - AssertionError: Completions (Z.z<tab>) correctly deduplicate: []
assert 0 == 1
+ where 0 = len([])
FAILED tests/test_completer.py::TestCompleter::test_greedy_completions - AssertionError: <Completion start=5 end=5 text='real' type='?', signature='?',> not found in []
FAILED tests/test_completer.py::TestCompleter::test_jedi - AssertionError: jedi >0.9 should complete and not crash
assert <Completion start=6 end=6 text='real' type='?', signature='?',> in set()
+ where <Completion start=6 end=6 text='real' type='?', signature='?',> = Completion(6, 6, 'real')
FAILED tests/test_completer.py::TestCompleter::test_matcher_suppression_with_jedi - AssertionError: 'keys' not found in []
FAILED tests/test_debugger.py::tests.test_debugger.can_exit
FAILED tests/test_debugger.py::tests.test_debugger.can_quit
FAILED tests/test_debugger.py::tests.test_debugger.test_ipdb_magics2
FAILED tests/test_debugger.py::test_decorator_skip_with_breakpoint - pexpect.exceptions.TIMEOUT: Timeout exceeded.
FAILED tests/test_text.py::test_eval_formatter - File "<string>", line 1
0[n//i for i in range(1,8)]
^^^
SyntaxError: invalid syntax
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Upstream release of parso solved the completer failures, we are down to 5: FAILED tests/test_debugger.py::tests.test_debugger.can_exit
FAILED tests/test_debugger.py::tests.test_debugger.can_quit
FAILED tests/test_debugger.py::tests.test_debugger.test_ipdb_magics2
FAILED tests/test_debugger.py::test_decorator_skip_with_breakpoint - pexpect.exceptions.TIMEOUT: Timeout exceeded.
FAILED tests/test_text.py::test_eval_formatter - File "<string>", line 1
0[n//i for i in range(1,8)]
^^^
SyntaxError: invalid syntax
=================== 5 failed, 1415 passed, 136 skipped, 3 xfailed, 42 warnings in 134.82s (0:02:14) ====================
|
Sorry, something went wrong.
even though it was passing locally for me on the same rc2?
krassowski
marked this pull request as ready for review
August 25, 2025 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14858