| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
This would be simpler if it was based on #6151, as you wouldn't have to store _model_id, but could just directly instantiate the comm with the correct id in the init method. On second thought, I guess you might still want to store the model id in case open() is called more than once. |
Sorry, something went wrong.
|
I think it would make more sense to me if we changed the widget class model_id from a property to an attribute, set the default to generating a new UUID, and then always set the comm id to the model id. Then setting the model_id becomes part of the standard trait machinery. |
Sorry, something went wrong.
|
Closing. will open a PR to your branch, used for PR #6151 . |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Simple change meant to allow widget model ids to be set externally.