FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update deprecated actions by ignotus666 · Pull Request #984 · jamulussoftware/jamuluswebsite · GitHub

Update deprecated actions - #984

Merged
ann0see merged 1 commit into
jamulussoftware:next-releasefrom
ignotus666:dep-actions
Apr 26, 2024
Merged

Update deprecated actions#984
ann0see merged 1 commit into
jamulussoftware:next-releasefrom
ignotus666:dep-actions

Conversation

ignotus666 commented Apr 18, 2024
edited
Loading

Copy link
Copy Markdown
Member

Short description of changes
Actions haven't been updated for some time and some versions are close to being unsupported.

Context: Fixes an issue? Related issues

Status of this Pull Request
2nd attempt - should be ready; tested and working on my fork.

What is missing until this pull request can be merged?

Does this need translation?

No.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

Copy link
Copy Markdown
Member Author

When testing the website artifact created by the gh action, the gemfile isn't there, leading to an error. If I manually paste it into the folder, it works fine. I don't really know much about this stuff... @ann0see any ideas?

Copy link
Copy Markdown
Member Author

Testing on a clone of my fork the website works fine, so something's happening in the gh action creating the artifact.

ann0see commented Apr 18, 2024

Copy link
Copy Markdown
Member

Thank you very much. That's odd. Does jekyll update create it?

ann0see commented Apr 18, 2024

Copy link
Copy Markdown
Member

I mean: the artifact is the compiled website, I think. So it doesn't have the gemfile. But the repo should.

Copy link
Copy Markdown
Member Author

@ann0see Huh... I just downloaded it again and tried it with the command jekyll serve (instead of bundle exec jekyll serve) and it worked. So it was just a case of me getting my commands mixed up...

ann0see merged commit 3d4db9c into jamulussoftware:next-release Apr 26, 2024
ignotus666 deleted the dep-actions branch June 21, 2024 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL