FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add "create" operation by hnguyen08 · Pull Request #10 · java-json-tools/json-patch · GitHub

/ json-patch Public

add "create" operation - #10

Open
hnguyen08 wants to merge 6 commits into
java-json-tools:masterfrom
hnguyen08:master
ConversationCommits (6)ChecksFiles changed
Open

add "create" operation#10
hnguyen08 wants to merge 6 commits into
java-json-tools:masterfrom
hnguyen08:master

Conversation

hnguyen08 commented Mar 24, 2014

Copy link
Copy Markdown

I'd like to extend JSON Patch and add a new "create" operation. It is exactly like "add", except it will not replace an existing value at the requested path. It will be useful in situations in where a client wants to ensure that they are not overwriting a value set by another client.

This was a suggestion from an email thread with the RFC6902 authors:

I think you've got it right; you can't do it in a fine-grained way with json-patch. Of course, you could use HTTP conditionals (e.g., If-Match), but that's more coarse-grained.
If you want to do this right now, I think the best thing to do would be to define a new operation and then use a new media type to differentiate between it and JSON Patch.
I'd be interested in starting a new version of json patch if we can get enough experience with this one to make it worthwhile...

Although it deviates from the RFC, I think it would be useful for others to use, perhaps in a custom JsonPatch implementation as you mentioned in #9.

Let me know what you think!

fge commented Mar 24, 2014

Copy link
Copy Markdown
Collaborator

I agree that this operation is nice, but indeed I'd like to keep RFC 6902 compatibility, which means I'll need to refactor and make JsonPatch abstract... That'll be for a 2.0 version.

As to the patch itself, it looks good, but I'd suggest the following changes:

  • renaming AddableOperation to AdditionOperation,
  • add a boolean to its protected constructor which would be true if we wanted to overwrite object members,
  • modify the code of addToObject() so that it exploit this boolean to know whether it should overwrite.

hnguyen08 commented Mar 25, 2014

Copy link
Copy Markdown
Author

Thanks! I'll make an update using your suggestions.

hnguyen08 commented Mar 25, 2014

Copy link
Copy Markdown
Author

Squashed

hnguyen08 commented Mar 31, 2014

Copy link
Copy Markdown
Author

Updated to make overwriteExisting final. Let me know what you think

fge commented Mar 31, 2014

Copy link
Copy Markdown
Collaborator

Excellent! Now I need to find the time to work on that project again... Right now I'm busy with json-schema-*...

hnguyen08 commented Apr 1, 2014

Copy link
Copy Markdown
Author

Thanks, I'll keep an eye out for any updates.

stephane-daviet-maif pushed a commit to stephane-daviet-maif/json-patch that referenced this pull request Apr 6, 2019
Merge pull request java-json-tools#10 from jtoelke/remove_optional_op…
91653fd 
…eration

Add remove? operation
BartekGravity pushed a commit to gravity9-tech/json-patch-path that referenced this pull request Jun 20, 2023
Merge pull request java-json-tools#10 from gravity9piotr/bugfix/807_j…
a7d8e11 
…son_pointer_double_slashes

#807 JsonPointer double slashes validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL