FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bug fix in move operation by vishwakarma · Pull Request #14 · java-json-tools/json-patch · GitHub

/ json-patch Public

bug fix in move operation - #14

Open
vishwakarma wants to merge 1 commit into
java-json-tools:masterfrom
vishwakarma:move_operation_bug_fix
ConversationCommits (1)ChecksFiles changed
Open

bug fix in move operation#14
vishwakarma wants to merge 1 commit into
java-json-tools:masterfrom
vishwakarma:move_operation_bug_fix

Conversation

vishwakarma commented Jul 28, 2014

Copy link
Copy Markdown

There was bug in factorization of diffs while finding pairs.
Example :
"first": { "b": [0, 1, 2] },
"second": { "b": [1, 2], "c": 0 ,"d":0}
patch obtained is :
{{ "op": "move", "from": "/b/0", "path": "/c"}, { "op": "move", "from": "/b/0", "path": "/d"}}
which is wrong, the correct patch generated should be
{ "op": "move", "from": "/b/0", "path": "/c"},{ "op": "add", "path": "/d", "value": 0}
There was bug in finding pair method, I have added necessary code fix for same.

fge commented Oct 31, 2014

Copy link
Copy Markdown
Collaborator

Uh, sorry, I only just noticed this pull request...

Does it also solve the other issue you mentioned?

vishwakarma commented Nov 1, 2014

Copy link
Copy Markdown
Author

Hi, the pull request doesn't solve all cases, it solve cases covered by shared example, The whole MOVE operation needs to revisit.

vishwakarma commented Dec 19, 2014

Copy link
Copy Markdown
Author

Hi, I have written java implementation names as zjsonpatch https://github.com/flipkart-incubator/zjsonpatch, it covers all cases which are currently missing in json-patch project.
Currently, This is being used in my some other project where daily 70+Million jsons are compared (checked for diff and applied same if diff found), this is live from last 3 months with no issues reported, Variations in json used are ranging from 5-300 keys with multiple level of nesting (array within object or vice-versa) and latency perceived is 99.9 percentile 1ms .

fge commented Dec 19, 2014

Copy link
Copy Markdown
Collaborator

@vishwakarma which cases are missing? None are missing. JSON Patch works and so does JSON Merge Patch.

And so does JSON Diff! It just doesn't optimize everything. But it works reliably.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL