| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Can you rename the param from "moveOrCopy" to "diffDoentRequireSource" or something more semantic about what is trying to be achieved. i.e. we shouldn't include test as well if that ever came up. |
Sorry, something went wrong.
|
Done. I'm not sure I have understand what you say about test. Maybe I should create an option objet that could evolve, rather than a boolean directly in constructor ? |
Sorry, something went wrong.
|
A boolean paramter to determine behaviour might be a code smell. I was thinking of solving this in a different way by extracting an interface from DiffProcessor with two implementations SourcedDiffProcessor and SourcelessDiffProcessor ( maybe the names could be better ) with two well defined static factory methods in the JsonDiff class. |
Sorry, something went wrong.
|
@huggsboson I create a DiffOptions class and a builder, to pass 'diffDoentRequireSource' option, I think it's more flexible. Build don't pass, there is a problem with a gradle dependency : http://repo.springsource.org/plugins-release/org/springframework/build/gradle/propdeps-plugin/0.0.7/propdeps-plugin-0.0.7.pom are only accessible on https. I don't know how to solve this, and I think is not reliable directly to my PR or the java-json-tool project. |
Sorry, something went wrong.
|
|
||
|
|
||
| public static JsonNode asJson(final JsonNode source, final JsonNode target, final boolean withMoveOrCopyOperation) | ||
| public static JsonNode asJson(final JsonNode source, final JsonNode target, DiffOptions options) |
There was a problem hiding this comment.
options param should be final
Sorry, something went wrong.
There was a problem hiding this comment.
done
Sorry, something went wrong.
could you show us your idea ? |
Sorry, something went wrong.
|
I'd like to see this feature become available. Is there anything else still needed for this? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
I need a patch without reference to the json source.
Related to issue #46