bugfix when handling array - #97
Open
wenhoujx wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a bug that all the operations in diffs are stateful in the sense that their operation depends on the operations before them.
The remove and add case breaks the diffs order b/c it removes and add to the end of diffs.
repro:
@Test void testJsonPatchBug() throws JsonProcessingException, JsonPatchException { JsonNode config1 = YAML_MAPPER.readTree("" + "foo:\n" + " - bar:\n" + " - baz: a\n" + " - baz: b\n" + " - baz: c\n" + " - bar:\n" + " - baz: d\n"); JsonNode config2 = YAML_MAPPER.readTree("" + "foo:\n" + "- bar:\n" + " - baz: d\n" + "- bar:\n" + " - baz: c\n" + " - baz: b\n" + " - baz: a\n"); Assertions.assertThat(JsonDiff.asJsonPatch(config1, config2).apply(config1)) .isEqualTo(config2); } # test fails the actual config is : foo: - bar: - baz: d - bar: - baz: c - baz: c - baz: a