This repository was archived by the owner on Nov 7, 2024. It is now read-only.
Fixes #32: Doubt about writeEscapedString() - #70
Open
lukasj wants to merge 1 commit into
Open
lukasj wants to merge 1 commit into
lukasj wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
m0mus
reviewed
Oct 31, 2017
m0mus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Any tests?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good to me. |
Sorry, something went wrong.
bravehorsie
reviewed
Nov 1, 2017
bravehorsie
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks like an excellent candidate for performance test.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Is this still done here or should the repository also be archived (like the README actually says)? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@keilw this was archived but we found an issue which needs to be fixed, so we unarchived this and will archive it (and port all changes to ee4j) once its done. Makes sense? |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reworked writeEscapedString to work with code points