FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add JSR375 Security API 1.0 Examples by vinayvishal · Pull Request #3 · javaee/tutorial-examples · GitHub

This repository was archived by the owner on Jan 25, 2019. It is now read-only.

Repository navigation

Add JSR375 Security API 1.0 Examples - #3

Merged
vinayvishal merged 1 commit into
javaee:masterfrom
vinayvishal:jsr375-examples
Jun 14, 2018
Merged

vinayvishal merged 1 commit into
javaee:masterfrom
vinayvishal:jsr375-examples

Conversation

Copy link
Copy Markdown
Contributor

1st example demonstrates built-in DatabaseIdentityStore usage as specified in JSR 375. Details can be found in the README of this example.

2nd example demonstrates CustomIdentityStore usage as specified in JSR 375. Details can be found in the README of this example.

Copy link
Copy Markdown
Contributor Author

@wmhopkins @bbuerkle , replaced the #1 with this #3. Review comments have already been incorporated in this request.

bshannon commented Jun 5, 2018

Copy link
Copy Markdown
Member

This pull request has been sitting here for a long time. Can we get the reviewers to review it,
or the submitter to cancel it?

Copy link
Copy Markdown
Member

Looks reasonable to me. I'm OK submitting it if it's still appropriate. (Don't know whether another PR providing equivalent or alternative content was ever submitted.)

@vinayvishal -- If this is still appropriate to submit, please go ahead.

Copy link
Copy Markdown

Hi Vinay - I just downloaded EE8 and I do not see the CustomIdentityStore example. I documented it, and based on earlier email from you, it was supposed to be available at tut-install/examples/security/security-api, which is what I documented. I received another comment from a user indicating that they could not find the example. Is there any plan to publish it?

Copy link
Copy Markdown

@vinayvishal @wmhopkins
Hi Vinay - I just downloaded EE8 and I do not see the CustomIdentityStore example. I documented it, and based on earlier email from you, it was supposed to be available at tut-install/examples/security/security-api, which is what I documented. I received another comment from a user indicating that they could not find the example. Is there any plan to publish it?

Also - the built-in-db-identity-store example is located at glassfish5/samples/security/jsr375 and not tut-install/examples/security/security-api/built-in-db-identity-store as expected and documented.

vinayvishal merged commit f86b428 into javaee:master Jun 14, 2018

Copy link
Copy Markdown
Contributor Author

Hi Barbara, I have merged it now.. 8.0 tutorial examples got released and integrated with SDK (20-Sep) before this PR was created (22-Sep) and hence it got missed out being added in release cycle and I guess that's why it was still open.

Copy link
Copy Markdown

Hi Vinay - two questions.

  1. Are there plans to re-release the SDK that would include this example?
  2. Where will the example be located? tut-install/examples/security/security-api, which is what I documented, or glassfish5/samples/security/jsr375, which is where the built-in-db-identity-store example is located?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL