Ninja code - #109
Merged
joaquinelio merged 19 commits intoJun 7, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
EzequielCaste
requested changes
May 30, 2020
EzequielCaste
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
corregir
Sorry, something went wrong.
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
| A fellow programmer who wants to work with `elem` in the second half of the function will be surprised... Only during the debugging, after examining the code they will find out that they're working with a clone! | ||
|
|
||
| Seen in code regularly. Deadly effective even against an experienced ninja. | ||
| Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon. | |
| Un colega programador que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon. |
Sorry, something went wrong.
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Copy link
Copy Markdown
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
joaquinelio
requested changes
May 30, 2020
joaquinelio
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Se ve lindo.
@ezzep66 , ¿seguimos con doble revisión?
Lo hice encima de la tuya así apenas se corrige la podés subir.
Si pensás que no hacen falta, disculpas.
La gramática no es el tema más importante en JS. Ni siquiera para la virtual machine jeje
Sorry, something went wrong.
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Comment thread
1-js/03-code-quality/04-ninja-code/article.md
Outdated
Copy link
Copy Markdown
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
qué se hace si @Sjesc no responde? podemos nosotros maintainers corregir? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Si, tenemos que corregir @ezzep66 @joaquinelio |
Sorry, something went wrong.
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
joaquinelio
approved these changes
Jun 7, 2020
11 sugerencias ok Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Copy link
Copy Markdown
|
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.