Symbol type by mariabp · Pull Request #115 · javascript-tutorial/es.javascript.info · GitHub

Translation to spanish ready to review :)

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mariabp
✅ vplentinax
❌ Developer

Developer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hola @mariabp
esta super genial la traducción, solo hay un pequeño detalle,
en todas las declaraciones le agregaste un espacio extra.
Por ejemplo:
let id = Symbol("id"); , debería ser let id = Symbol("id"); (le quité un espacio entre el let y el id

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Listo! Ya eliminé los espacios extras, que raro que los puse 🤔 . Me dices que te parece :)

Done

LGTM🚀

"Se garantiza que los símbolos son únicos" me parece que suena más natural, lo dejo a tu criterio.
"Aunque declaremos varios Symbols con la misma descripción, éstos ..."

Estoy de acuerdo contigo!

auto-convierten, para ser consistentes

Los Symbols nos permiten crear propiedades "ocultas" en un objeto, a las cuales ninguna otra parte del código puede acceder ni sobre-escribir.

No se debe traducir los nombres de las variables, por ejemplo de "user" a "usuario"

Don't translate variables, classes, identifiers.

Revisenlo para yo agregar los cambios y no tener que volverlos a revisar una vez arregle el conflicto de estructura.

@ezzep66
te lo paso porque puse varias cosas

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

/done

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

First translation

6f952dc

javascript-translate-bot added the review needed label Oct 22, 2019

javascript-translate-bot requested a review from a team October 22, 2019 15:33

lizzie136 requested changes Oct 29, 2019

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Oct 29, 2019

mariabp and others added 2 commits November 1, 2019 11:35

Update article.md

de0b438

Listo! Ya eliminé los espacios extras, que raro que los puse 🤔 . Me dices que te parece :)

Deleted extra space between declaration and name of variable

0a786f0

lizzie136 added review needed and removed changes requested labels Nov 15, 2019

lizzie136 self-requested a review November 15, 2019 15:50

lizzie136 approved these changes Nov 15, 2019

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Nov 15, 2019

lizzie136 requested review from caballerof and tscandalitta November 15, 2019 15:51

tscandalitta reviewed Nov 20, 2019

View reviewed changes

vplentinax changed the title First translation Symbol type Jun 7, 2020

iliakan mentioned this pull request Jun 7, 2020

Spanish Translation Progress #17

Open

vplentinax requested review from EzequielCaste and joaquinelio June 7, 2020 19:21

joaquinelio requested changes Jun 8, 2020

View reviewed changes

javascript-translate-bot added the changes requested label Jun 8, 2020

vplentinax and others added 5 commits June 10, 2020 00:54

Update 1-js/04-object-basics/03-symbol/article.md

239004b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

969795a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

82a0bb0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

68d693c

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

505e32b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

vplentinax and others added 3 commits June 10, 2020 19:34

Update 1-js/04-object-basics/03-symbol/article.md

5015fc3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

6ba4d07

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

63349ea

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

vplentinax mentioned this pull request Jun 13, 2020

Symbol type #252

Merged

vplentinax closed this Jun 13, 2020

               ```
-              Symbols are guaranteed to be unique. Even if we create many symbols with the same description, they are different values. The description is just a label that doesn't affect anything.
+              Los Symbols están garantizados a ser únicos. Aunque declaremos varios Symbols con la misma descripción éstos tendrán valores distintos. La descripción es solamente una etiqueta que no afecta nada más.

-              ````warn header="Symbols don't auto-convert to a string"
-              Most values in JavaScript support implicit conversion to a string. For instance, we can `alert` almost any value, and it will work. Symbols are special. They don't auto-convert.
+              ````warn header="Symbols no se auto convierten a String"

+              ## Propiedades "Ocultas"
-              Symbols allow us to create "hidden" properties of an object, that no other part of code can occasionally access or overwrite.
+              Los Symbols nos permiten crear propiedades "ocultas" en un objeto, las cuales ninguna otra parte del código puede accesar ni sobre-escribir.

Symbol type by mariabp · Pull Request #115 · javascript-tutorial/es.javascript.info · GitHub

Uh oh!

Symbol type - #115

Symbol type#115mariabp wants to merge 11 commits intojavascript-tutorial:masterjavascript-tutorial/es.javascript.info:masterfrom mariabp:spanish-symbolCopy head branch name to clipboard

Conversation

mariabp commented Oct 22, 2019

Uh oh!

CLAassistant commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Oct 29, 2019

Uh oh!

mariabp commented Nov 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

tscandalitta Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

mariabp Nov 24, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta commented Nov 20, 2019

Uh oh!

vplentinax commented Jun 7, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 8, 2020

Uh oh!

vplentinax commented Jun 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Symbol type#115
mariabp wants to merge 11 commits into
javascript-tutorial:masterfrom
mariabp:spanish-symbol

CLAassistant commented Oct 22, 2019 •
edited
Loading

mariabp commented Nov 8, 2019 •
edited
Loading