FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Static properties and methods by cortizg · Pull Request #172 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

Static properties and methods - #172

Merged
joaquinelio merged 2 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.1-09-03
Jun 21, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Static properties and methods#172
joaquinelio merged 2 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.1-09-03

Conversation

cortizg commented May 9, 2020

Copy link
Copy Markdown
Contributor

No description provided.

javascript-translate-bot requested a review from a team May 9, 2020 04:08

javascript-translate-bot commented May 9, 2020

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 167 ⁉️

cortizg commented May 9, 2020

Copy link
Copy Markdown
Contributor Author

#172 replace #167

cortizg mentioned this pull request May 10, 2020
Open
joaquinelio requested changes Jun 21, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Está perfecta. O estoy ciego. Deberían coincidir las líneas, agregué 2 suggest.

Comment thread 1-js/09-classes/03-static-properties-methods/article.md
alert( article.title ); // Today's digest
alert( article.title ); // Resumen de hoy
```
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.

joaquinelio Jun 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.

Comment thread 1-js/09-classes/03-static-properties-methods/article.md
class Animal {
static planet = "Earth";

static planet = "Tierra";

joaquinelio Jun 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
static planet = "Tierra";
static planet = "Tierra";

javascript-translate-bot commented Jun 21, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio merged commit 05f7589 into javascript-tutorial:master Jun 21, 2020

javascript-translate-bot commented Jun 21, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joaquinelio joaquinelio requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL