FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Numbers by joaquinelio · Pull Request #200 · javascript-tutorial/es.javascript.info · GitHub

Numbers - #200

Merged
vplentinax merged 4 commits into
javascript-tutorial:masterfrom
joaquinelio:numbers
Jun 6, 2020
Merged

Numbers#200
vplentinax merged 4 commits into
javascript-tutorial:masterfrom
joaquinelio:numbers

Conversation

Copy link
Copy Markdown
Member

1.5.2 number completito y probado con server local

NOTAS

diff - Me basé en EN.javascript.info
que es más nuevo, tiene algunas correcciones,
e incluye breve descripción de bigInt (hay un link al capítulo bigInt que no existe -easy fix, boss-)

Volé (parte de) un párrafo que tiene sentido en inglés pero no en castellano,
referida a cómo abrevian en palabras los números "somos perezosos", en español no usamos esas abreviaturas y en ESTE particular caso no tiene sentido explicarlas y aclarar que nosotros no lo hacemos.

EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

me pareció bien.
sugerí algunos cambios.
🚀 🍕

Comment thread 1-js/05-data-types/02-number/article.md Outdated
Comment thread 1-js/05-data-types/02-number/article.md Outdated
Comment thread 1-js/05-data-types/02-number/article.md Outdated
Comment thread 1-js/05-data-types/02-number/article.md Outdated

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio and others added 2 commits June 2, 2020 00:25
/done

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
/done

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
joaquinelio changed the title numbers Numbers Jun 3, 2020
joaquinelio requested a review from EzequielCaste June 4, 2020 06:36

EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok

vplentinax merged commit e94892d into javascript-tutorial:master Jun 6, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

joaquinelio deleted the numbers branch July 15, 2020 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL