FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Functions by vplentinax · Pull Request #230 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

Functions - #230

Merged
vplentinax merged 31 commits into
javascript-tutorial:masterfrom
vplentinax:Giorgiosaud-function-basics
Jul 3, 2020
ConversationCommits (31)ChecksFiles changed
Merged

Functions#230
vplentinax merged 31 commits into
javascript-tutorial:masterfrom
vplentinax:Giorgiosaud-function-basics

Conversation

vplentinax commented Jun 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Este PR es la corrección al articulo traducido por el colaborador Giorgiosaud Functions #96 . Dicho PR será cerrado y reenumerado en el Issue 17.

javascript-translate-bot requested a review from a team June 5, 2020 17:34
vplentinax changed the title Giorgiosaud-PR95-correccion Conditional operators: if, '?' Jun 5, 2020
iliakan mentioned this pull request Jun 5, 2020
Open
vplentinax changed the title Conditional operators: if, '?' Functions Jun 5, 2020
EzequielCaste requested changes Jun 15, 2020
View reviewed changes

EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

casi listo, algunas correcciones

Comment thread 1-js/02-first-steps/15-function-basics/1-if-else-required/task.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/2-rewrite-function-question-or/task.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated

javascript-translate-bot commented Jun 15, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 16 commits June 15, 2020 11:05
Update 1-js/02-first-steps/15-function-basics/1-if-else-required/task.md
f95071e
Update 1-js/02-first-steps/15-function-basics/2-rewrite-function-ques…
09ffe2a 
…tion-or/task.md
Update 1-js/02-first-steps/15-function-basics/article.md
70b78b8
Update 1-js/02-first-steps/15-function-basics/article.md
bdfa86a
Update 1-js/02-first-steps/15-function-basics/article.md
f92cde2
Update 1-js/02-first-steps/15-function-basics/article.md
71c8b5f
Update 1-js/02-first-steps/15-function-basics/article.md
37463e9
Update 1-js/02-first-steps/15-function-basics/article.md
70e926b
Update 1-js/02-first-steps/15-function-basics/article.md
03bc402
Update 1-js/02-first-steps/15-function-basics/article.md
d5c47ee
Update 1-js/02-first-steps/15-function-basics/article.md
f6655c0 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Update 1-js/02-first-steps/15-function-basics/article.md
023b516 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Update 1-js/02-first-steps/15-function-basics/article.md
25dfc7f 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Update 1-js/02-first-steps/15-function-basics/article.md
f4e78a7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Update 1-js/02-first-steps/15-function-basics/article.md
d944b06 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Update 1-js/02-first-steps/15-function-basics/article.md
6e08312 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

vplentinax commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

/done

javascript-translate-bot requested a review from a team June 16, 2020 16:36
joaquinelio reviewed Jul 2, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

varios cambiecitos
Pero muy buen schooling, so dont wait for me
cambia lo que quieras y MERGE

Partimos de un falso "mucho hecho", resignamos a que eran menos de 20.
Ahora 60... ¡UN TERCIO DEL SITIO! Y los PR, dentro del mes.
Qué sino para festejo.

Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
vplentinax and others added 14 commits July 2, 2020 17:51
Update 1-js/02-first-steps/15-function-basics/article.md
05538ed 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
bd731dc 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
7312c8f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
06a0d8f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
3dde6f3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
22dec62 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
7776d6e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
fb1b96f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
86af996 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
5b73d94 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
b889666 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
ca8c18d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
9f1b86d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 1-js/02-first-steps/15-function-basics/article.md
bd45ddd 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

vplentinax commented Jul 2, 2020

Copy link
Copy Markdown
Contributor Author

/done

javascript-translate-bot requested a review from a team July 2, 2020 21:55
vplentinax merged commit ca8f297 into javascript-tutorial:master Jul 3, 2020

javascript-translate-bot commented Jul 3, 2020

Copy link
Copy Markdown

Error: the article has another translator @Giorgiosaud, not @vplentinax in the Progress Issue #17. Please update the progress issue or ask maintainers to do so.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

EzequielCaste EzequielCaste requested changes
joaquinelio joaquinelio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL