Promise API - #313
Merged
joaquinelio merged 17 commits intoAug 6, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vplentinax
self-requested a review
August 3, 2020 02:30
vplentinax
requested changes
Aug 5, 2020
vplentinax
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pequeñas cositas. Se cambian y nos fuimos!.
Sorry, something went wrong.
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Copy link
Copy Markdown
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
Confundí resolve con fulfilled (solo successful) crei que puso "settled" para indicar ambos. My bad. Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Copy link
Copy Markdown
Member
Author
|
/done |
Sorry, something went wrong.
vplentinax
approved these changes
Aug 5, 2020
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Yo apruebo esta traducción!
Sorry, something went wrong.
maksumi
approved these changes
Aug 6, 2020
maksumi
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Hay como dos o tres typos. Excelente traducción, solo unas pequeñas sugerencias nada serias y una pequeña llamada de atención al "exceso de comas". Merge it!
Sorry, something went wrong.
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
Comment thread
1-js/11-async/05-promise-api/article.md
Outdated
De acuerdo, se lee mucho mejor "Veremos" Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Copy link
Copy Markdown
|
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branch "papi"
edito:
@vplentinax , gracias por el buen humor
parece que tengo que borrar el coment porque incomoda a potenciales revisores...