FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Async/await by joaquinelio · Pull Request #317 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

Async/await - #317

Merged
vplentinax merged 8 commits into
javascript-tutorial:masterfrom
joaquinelio:asyawa
Jul 31, 2020
ConversationCommits (8)ChecksFiles changed
Merged

Async/await#317
vplentinax merged 8 commits into
javascript-tutorial:masterfrom
joaquinelio:asyawa

Conversation

joaquinelio commented Jul 23, 2020

Copy link
Copy Markdown
Member

No description provided.

javascript-translate-bot requested a review from a team July 23, 2020 02:06
iliakan mentioned this pull request Jul 23, 2020
Open
dbritto-dev suggested changes Jul 30, 2020
View reviewed changes
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/solution.md Outdated
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/task.md Outdated
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/task.md Outdated
Comment thread 1-js/11-async/08-async-await/03-async-from-regular/task.md Outdated
Comment thread 1-js/11-async/08-async-await/03-async-from-regular/task.md Outdated
Comment thread 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md Outdated

javascript-translate-bot commented Jul 30, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio and others added 6 commits July 30, 2020 09:39
Update 1-js/11-async/08-async-await/01-rewrite-async/solution.md
f0e33f3 
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
Update 1-js/11-async/08-async-await/01-rewrite-async/task.md
36ade9e 
me da igual...

Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
Update 1-js/11-async/08-async-await/01-rewrite-async/task.md
0d4ae3d 
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
Update 1-js/11-async/08-async-await/03-async-from-regular/task.md
2d7709d 
ok, latin suena mejor que mal español

Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
Update 1-js/11-async/08-async-await/03-async-from-regular/task.md
e8f5a9e 
¿por? se entiende, pero...

Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
Update 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md
8d85031 
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>

joaquinelio commented Jul 30, 2020

Copy link
Copy Markdown
Member Author

/done

Update task.md
46acfaa 
s de mas linea 4
maldito teclado
maksumi approved these changes Jul 30, 2020
View reviewed changes

maksumi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

¡Vientos!

vplentinax previously approved these changes Jul 30, 2020
View reviewed changes

vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fuímonos! (pronombre enclítico)

vplentinax commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

Bueno, realmente debí esperar que @danilobrinu aprobara los cambios. Retiro mi "fuímonos"!

vplentinax dismissed their stale review July 30, 2020 22:42

Other reviewer is here!

dbritto-dev commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

@vplentinax jajaja aca estoy :p

vplentinax commented Jul 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

dbritto-dev commented Jul 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

vplentinax commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

  1. Ve a "Files Changed"
  2. Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
  3. Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

dbritto-dev commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

  1. Ve a "Files Changed"
  2. Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
  3. Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

@vplentinax listo 👍

vplentinax merged commit c4cce12 into javascript-tutorial:master Jul 31, 2020

javascript-translate-bot commented Jul 31, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

joaquinelio deleted the asyawa branch August 1, 2020 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

maksumi maksumi approved these changes
vplentinax vplentinax left review comments
+1 more reviewer
dbritto-dev dbritto-dev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL