FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Scripts: async, defer by dbritto-dev · Pull Request #324 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

Scripts: async, defer - #324

Merged
joaquinelio merged 26 commits into
javascript-tutorial:masterfrom
dbritto-dev:master
Jul 29, 2020
ConversationCommits (26)ChecksFiles changed
Merged

Scripts: async, defer#324
joaquinelio merged 26 commits into
javascript-tutorial:masterfrom
dbritto-dev:master

Conversation

dbritto-dev commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

No description provided.

CLAassistant commented Jul 26, 2020 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

iliakan mentioned this pull request Jul 26, 2020
Open
joaquinelio self-requested a review July 27, 2020 03:47
joaquinelio requested changes Jul 27, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Está bien, typos y tildes

podes aceptar, pelearme o ignorarme...
pero...
Creo que te ofreciste para review?
de los PR, con etiquetas "review needed", son los que no tuvieron revisión
o la tuvieron y el autor hizo/rechazó los cambios
Si está esperando "change req" no creo que valga la pena revisar, que el autor revise primero

Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated
Comment thread 2-ui/5-loading/02-script-async-defer/article.md Outdated

javascript-translate-bot commented Jul 27, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-dev and others added 19 commits July 27, 2020 00:02
Update 2-ui/5-loading/02-script-async-defer/article.md
04fe54f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
f13cceb 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
344e441 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
bb5d273 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update article.md
5c441b2
Update 2-ui/5-loading/02-script-async-defer/article.md
ad6a1fd 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
89185ba 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
6475b1c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
f576eb0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
656d411 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
91d7706 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
83e8176 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
844042d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
e4aecf7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
91b3af0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
fe973fc 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
e925239 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
a0b8670 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
a2449ac 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-dev and others added 3 commits July 27, 2020 00:48
Update 2-ui/5-loading/02-script-async-defer/article.md
212eb55 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 2-ui/5-loading/02-script-async-defer/article.md
60d5e05 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update article.md
dea6a11

dbritto-dev commented Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

/done

dbritto-dev requested a review from joaquinelio July 27, 2020 18:34
joaquinelio approved these changes Jul 27, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok.
autor y/o 2do reviewer,
*clic para arreglar nro linea, algo menor
*No estoy convencido de la tabla en 185 (de origen), pero el evento y la relacion con los scripts se explican bien en el art.
Más que ok.

Comment thread 2-ui/5-loading/02-script-async-defer/article.md
Update 2-ui/5-loading/02-script-async-defer/article.md
b326102 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev commented Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

/done

dbritto-dev requested a review from joaquinelio July 27, 2020 23:35
vplentinax approved these changes Jul 29, 2020
View reviewed changes

vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok!

joaquinelio merged commit b565bbb into javascript-tutorial:master Jul 29, 2020

javascript-translate-bot commented Jul 29, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vplentinax vplentinax approved these changes
joaquinelio Awaiting requested review from joaquinelio

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL