FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

From the orbital height by Leired7 · Pull Request #331 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

From the orbital height - #331

Merged
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
Leired7:From-the-orbital-height
Aug 5, 2020
ConversationCommits (7)ChecksFiles changed
Merged

From the orbital height#331
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
Leired7:From-the-orbital-height

Conversation

Leired7 commented Aug 2, 2020

Copy link
Copy Markdown
Contributor

Hay unos cuantos términos que no he traducido: Custom elements, Shadow DOM, CSS Scoping , Event retargeting .... espero al consenso : D

joaquinelio self-requested a review August 3, 2020 16:48
joaquinelio requested changes Aug 3, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

¿Consenso? ¡JA! Motivo de pelea.
Pero sí, algunas cosas nos fuimos amoldando...
Tiendo a dejar en inglés más que otros, especialmente en nombres muy específicos.
¿Alguien tradujo "pen-drive" alguna vez?

Comment thread 8-web-components/1-webcomponents-intro/article.md Outdated
Comment thread 8-web-components/1-webcomponents-intro/article.md Outdated
Comment thread 8-web-components/1-webcomponents-intro/article.md Outdated
Comment thread 8-web-components/1-webcomponents-intro/article.md Outdated
Comment thread 8-web-components/1-webcomponents-intro/article.md Outdated

javascript-translate-bot commented Aug 3, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Leired7 and others added 5 commits August 4, 2020 08:17
Update 8-web-components/1-webcomponents-intro/article.md
88a6bc4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 8-web-components/1-webcomponents-intro/article.md
df30b4e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 8-web-components/1-webcomponents-intro/article.md
3b42b4f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 8-web-components/1-webcomponents-intro/article.md
0cf4c60 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 8-web-components/1-webcomponents-intro/article.md
911604f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Leired7 commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

/done

joaquinelio approved these changes Aug 4, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok. Aunque un segundo revisor probablemente pida más español.
O más aclaraciones. Supongo que ya debe saberse lo que es DOM porque no lo explica acá,
tampoco se si "shadow DOM". Si fuera la primera referencia, decir por qé "shadow".
"DOM interno"?

Leired7 commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

Supongo que "shadow DOM" será porque lo explicara más adelante... ya veremos si pasa el segundo review. Gracias :D

vplentinax approved these changes Aug 5, 2020
View reviewed changes

vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Me gusta la traducción. Fluida y clara. Apruebo con o sin aprobar mi sugerencia en el tema del shadow DOM. Pero esperamos a que el autor nos indique que prefiere antes del merge.

Comment thread 8-web-components/1-webcomponents-intro/article.md
joaquinelio merged commit 15e3723 into javascript-tutorial:master Aug 5, 2020
iliakan mentioned this pull request Aug 5, 2020
Open

javascript-translate-bot commented Aug 5, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

joaquinelio commented Aug 5, 2020

Copy link
Copy Markdown
Member

@Leired7
disculpame hice merge sin esperar tu feedback, asumi que estarias de acuerdo
Pero siempre es bienvenido un nuevo PR para proponer cambios

Leired7 commented Aug 5, 2020 via email

Copy link
Copy Markdown
Contributor Author

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joaquinelio joaquinelio approved these changes
vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL