FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TextDecoder and TextEncoder by homero304 · Pull Request #338 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

TextDecoder and TextEncoder - #338

Merged
joaquinelio merged 3 commits into
javascript-tutorial:masterfrom
homero304:TextDecoder-and-TextEncoder
Aug 11, 2020
ConversationCommits (3)ChecksFiles changed
Merged

TextDecoder and TextEncoder#338
joaquinelio merged 3 commits into
javascript-tutorial:masterfrom
homero304:TextDecoder-and-TextEncoder

Conversation

homero304 commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

Buenas tardes, podrian revisar mi pull request de favor?
gracias

saludos,
Homero Enrique Marin Galindo

CLAassistant commented Aug 9, 2020 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

homero304 changed the title traduccion al espaniol TextDecoder and TextEncoder Aug 9, 2020
iliakan mentioned this pull request Aug 9, 2020
Open
joaquinelio self-requested a review August 9, 2020 18:27
joaquinelio requested changes Aug 9, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Muy bueno.
Las unicas objeciones son de estilo.

NOTA: código.
Parece bien hecho, acá es fácil de seguir,
pero usualmente no nos arriesgamos a modificar más que los // comentarios
porque, programadores, nos gusta adornarlos con bugs.
Si loss modificas, sería bueno que tengas el server local instalado para probarlos.

Comment thread 4-binary/02-text-decoder/article.md Outdated
## TextEncoder

[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) does the reverse thing -- converts a string into bytes.
[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) hace lo contrario -- convierte un string en bytes.

joaquinelio Aug 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

El doble guion -- es convertido por el server en guion largo — (no se ve asi en el git) .
En español el uso es — algo — distinto.

A veces lo dejo cuando es una lissta porque se ve maás claro,
opcion — hace tal cosa
opcion — hace tal cosa

pero como lo usa acá se ve mejor cambiarlo por ":"

Suggested change
[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) hace lo contrario -- convierte un string en bytes.
[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) hace lo contrario: convierte un string en bytes.

homero304 Aug 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

/done

Comment thread 4-binary/02-text-decoder/article.md Outdated
¿Qué pasa si los datos binarios son en realidad un string? Por ejemplo, recibimos un archivo con datos textuales.

The build-in [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) object allows to read the value into an actual JavaScript string, given the buffer and the encoding.
Al proporcionar el búfer y la codificación, el objeto [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) nos permite leer el texto de un conjunto de datos binarios y convertirlo en un dato de tipo string de JavaScript.

joaquinelio Aug 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No está NADA mal,
pero que el objeto importante esté al principio, (a veces combinado con la voz pasiva) tiene un propósito didáctico.
bufer y codificacion, secundarioss, quedan relegados al final de la oración

Suggested change
Al proporcionar el búfer y la codificación, el objeto [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) nos permite leer el texto de un conjunto de datos binarios y convertirlo en un dato de tipo string de JavaScript.
El objeto [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) nos permite leer el texto de un conjunto de datos binarios y convertirlo en un dato de tipo string de JavaScript, dados el búfer y la codificación.

homero304 Aug 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

/done

javascript-translate-bot commented Aug 9, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

homero304 commented Aug 9, 2020

Copy link
Copy Markdown
Contributor Author

Si, para ver los cambios, tengo el server corriendo local en la computadora

homero304 commented Aug 9, 2020

Copy link
Copy Markdown
Contributor Author

/done

joaquinelio approved these changes Aug 10, 2020
View reviewed changes

joaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍
bytheway,
podes discutirme las sugerencias, o rescribirlas, nadie es perfecto.
Edit:
Noto que me siguen figurando las recomendaciones,
supongo que las hiciste localmente y las subiste, lo que me da igual,
Pero si aceptaste las modificaciones "tal cual" las puse, es mucho más rápido usar el botón
"commit suggestion"

vplentinax approved these changes Aug 11, 2020
View reviewed changes

vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Todo Ok!

joaquinelio merged commit b3ff949 into javascript-tutorial:master Aug 11, 2020

javascript-translate-bot commented Aug 11, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

homero304 deleted the TextDecoder-and-TextEncoder branch August 19, 2020 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joaquinelio joaquinelio approved these changes
vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL