FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Capturing groups by EzequielCaste · Pull Request #345 · javascript-tutorial/es.javascript.info · GitHub

/ es.javascript.info Public

Capturing groups - #345

Merged
EzequielCaste merged 5 commits into
javascript-tutorial:masterfrom
EzequielCaste:translate-capturing-groups
Aug 13, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Capturing groups#345
EzequielCaste merged 5 commits into
javascript-tutorial:masterfrom
EzequielCaste:translate-capturing-groups

Conversation

EzequielCaste commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

No description provided.

iliakan mentioned this pull request Aug 11, 2020
Open
joaquinelio requested changes Aug 12, 2020
View reviewed changes

joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Por perezoso no verifiqué si hay version mas nueva con ingles
ni si hay más archivos por traducir que estos,
usualmente lo hago como parte del review

Que aburrido que es este tema.
Extraño a @cortizg...

No lo habia leido, me hubiera venido bien lo de matchall y lo de grupo con nombre
este es mi regexp para el api issue17:

/([[\sX]])\s([.+])\s?((http[.\S]+))\s?((@\w+))?\s?(#\d+)?/

bytheway,
en este proyecto no importa para los marcados [X],
pero por esto del formato del match deberias respetar los campos,
al poner 2 autores 2 pr, o cosas ssin los identif que separan los campos, el bot se confundiría.

Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
Comment thread 9-regular-expressions/11-regexp-groups/article.md
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated

javascript-translate-bot commented Aug 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 4 commits August 12, 2020 10:51
Update 9-regular-expressions/11-regexp-groups/article.md
8fa499e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 9-regular-expressions/11-regexp-groups/article.md
46f5f90 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update 9-regular-expressions/11-regexp-groups/article.md
a5e74b8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Apply suggestions from code review
73300d6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
EzequielCaste commented Aug 12, 2020
View reviewed changes

EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

otro cambio

joaquinelio commented Aug 12, 2020

Copy link
Copy Markdown
Member

@EzequielCaste
"named xxxxxxx"
aparece en arts de
objetos (usaron como vos, "con nombre")
clases
regex

"xxxobjetos/clases/regxx con nombre"
me parece feo, pero por consistencia, te parece, lo dejamos asi ?
decime como lo pones y lo dejo igual en classes

EzequielCaste commented Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

@EzequielCaste
"named xxxxxxx"
aparece en arts de
objetos (usaron como vos, "con nombre")
clases
regex

"xxxobjetos/clases/regxx con nombre"
me parece feo, pero por consistencia, te parece, lo dejamos asi ?
decime como lo pones y lo dejo igual en classes

ok lo dejamos como Grupo con nombre

aunque me gusta más la otra forma...queda más profesional

EzequielCaste commented Aug 13, 2020
View reviewed changes

EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

listo

EzequielCaste merged commit 8082e03 into javascript-tutorial:master Aug 13, 2020

javascript-translate-bot commented Aug 13, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joaquinelio joaquinelio requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL