Browser default actions by homero304 · Pull Request #378 · javascript-tutorial/es.javascript.info · GitHub

please review my PR

Creo que no hay errores y todas son sugerencias de estilo, aplicala s o cambialas si queres

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…ls/solution.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…n/solution.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>

….view/index.html Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…4/es.javascript.info into Browser-default-actions

/done

¿me disculpas que haya agregado mas cosas? de estilo tambien

salvo un acento faltante que note haciendo zoom

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…n/task.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

/done

👍

Bien!

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

javascript-translate-bot added the review needed label Sep 11, 2020

Browser default actions

243a87c

homero304 force-pushed the Browser-default-actions branch from a5d87fc to 243a87c Compare September 11, 2020 03:20

joaquinelio requested changes Sep 11, 2020

View reviewed changes

javascript-translate-bot removed the review needed label Sep 11, 2020

javascript-translate-bot added the changes requested label Sep 11, 2020

joaquinelio mentioned this pull request Sep 11, 2020

Spanish Translation Progress #17

Open

omero329 and others added 7 commits September 11, 2020 08:25

Update 2-ui/2-events/04-default-browser-action/article.md

c17b5f6

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/article.md

91cf14a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

'Entonces','de inmediato'

41f89c1

Update 2-ui/2-events/04-default-browser-action/1-why-return-false-fai…

9389b69

…ls/solution.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…

52bdeda

…n/solution.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/3-image-gallery/source…

febee0a

….view/index.html Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Merge branch 'Browser-default-actions' of https://github.com/homero30…

9bd14bd

…4/es.javascript.info into Browser-default-actions

javascript-translate-bot added review needed and removed changes requested labels Sep 11, 2020

joaquinelio requested changes Sep 12, 2020

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Sep 12, 2020

omero329 and others added 5 commits September 12, 2020 10:45

Update 2-ui/2-events/04-default-browser-action/article.md

b79e278

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…

f074459

…n/task.md Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/article.md

b18160b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/article.md

95bda95

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/04-default-browser-action/article.md

ae338c5

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

javascript-translate-bot added review needed and removed changes requested labels Sep 12, 2020

javascript-translate-bot requested a review from a team September 12, 2020 15:46

joaquinelio approved these changes Sep 12, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Sep 12, 2020

vplentinax approved these changes Sep 14, 2020

View reviewed changes

vplentinax added ready to merge and removed needs +1 labels Sep 14, 2020

joaquinelio merged commit 5d87fd8 into javascript-tutorial:master Sep 15, 2020

Browser default actions by homero304 · Pull Request #378 · javascript-tutorial/es.javascript.info · GitHub

Uh oh!

Browser default actions - #378

Browser default actions#378joaquinelio merged 13 commits intojavascript-tutorial:masterjavascript-tutorial/es.javascript.info:masterfrom homero304:Browser-default-actionshomero304/es.javascript.info:Browser-default-actionsCopy head branch name to clipboard

Conversation

homero304 commented Sep 11, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 11, 2020

Uh oh!

homero304 commented Sep 11, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 12, 2020

Uh oh!

homero304 commented Sep 12, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Browser default actions#378
joaquinelio merged 13 commits into
javascript-tutorial:masterfrom
homero304:Browser-default-actions