FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Property flags and descriptors by longo-andrea · Pull Request #196 · javascript-tutorial/it.javascript.info · GitHub

/ it.javascript.info Public

Property flags and descriptors - #196

Merged
longo-andrea merged 6 commits into
javascript-tutorial:masterfrom
longo-andrea:article/property-descriptors
Feb 1, 2021
ConversationCommits (6)ChecksFiles changed
Merged

Property flags and descriptors#196
longo-andrea merged 6 commits into
javascript-tutorial:masterfrom
longo-andrea:article/property-descriptors

Conversation

longo-andrea commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

In questo articolo non è stato facile decidere cosa tenere in inglese e cosa tradurre in italiano

javascript-translate-bot requested a review from a team January 27, 2021 21:02
javascript-translate-bot mentioned this pull request Jan 27, 2021
Open
Apply suggestions from code review
ce13c67 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>

longo-andrea commented Jan 27, 2021

Copy link
Copy Markdown
Contributor Author

/done

Dorin-David reviewed Jan 28, 2021
View reviewed changes

Dorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ci sono alcune piccole modifiche e suggerimenti. Ottima traduzione, comunque!

longo-andrea and others added 3 commits January 29, 2021 20:50
Apply suggestions from code review
7578a6b 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
Update 1-js/07-object-properties/01-property-descriptors/article.md
9d70d12 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
Update 1-js/07-object-properties/01-property-descriptors/article.md
900083d 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>

longo-andrea commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

/done

pasor1 approved these changes Jan 31, 2021
View reviewed changes

pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Un paio di note

Comment thread 1-js/07-object-properties/01-property-descriptors/article.md
@@ -120,21 +120,21 @@ user.name = "Pete"; // Error: Cannot assign to read only property 'name'
*/!*

pasor1 Jan 31, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ci sarebbe il commento nel codice da tradurre, linea 119

longo-andrea Jan 31, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Qui non ho tradotto perché suppongo (ma non sono sicuro) che sia il messaggio di errore che ti appare.. e ho paura che traducendolo perda di senso, visto che poi non apparirà mai in italiano... però non ci metterei la mano sul fuoco, smentitemi se sto dicendo una cavolata

Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Apply suggestions from code review
5edd17b 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
longo-andrea merged commit a86fbfc into javascript-tutorial:master Feb 1, 2021

javascript-translate-bot commented Feb 1, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

longo-andrea deleted the article/property-descriptors branch February 7, 2021 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pasor1 pasor1 approved these changes
+1 more reviewer
Dorin-David Dorin-David left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL