FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Private and protected properties and method by longo-andrea · Pull Request #240 · javascript-tutorial/it.javascript.info · GitHub

/ it.javascript.info Public

Private and protected properties and method - #240

Merged
pasor1 merged 5 commits into
javascript-tutorial:masterfrom
longo-andrea:article/private-protected-methods
Mar 7, 2021
ConversationCommits (5)ChecksFiles changed
Merged

Private and protected properties and method#240
pasor1 merged 5 commits into
javascript-tutorial:masterfrom
longo-andrea:article/private-protected-methods

Conversation

longo-andrea commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

javascript-translate-bot requested a review from a team March 5, 2021 21:29
longo-andrea mentioned this pull request Mar 6, 2021
Open
Dorin-David suggested changes Mar 6, 2021
View reviewed changes

Dorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ho suggerito alcune modifiche

javascript-translate-bot commented Mar 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Apply suggestions from code review
e859b82 
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

/done

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

Ho aggiunto qui la traduzione del titolo del capitolo, mi ero completamente dimenticato 😅

pasor1 requested changes Mar 7, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated

javascript-translate-bot commented Mar 7, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Apply suggestions from code review
23ca259 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

/done

javascript-translate-bot requested a review from a team March 7, 2021 14:56
pasor1 merged commit 86f5d0a into javascript-tutorial:master Mar 7, 2021
longo-andrea deleted the article/private-protected-methods branch March 7, 2021 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pasor1 pasor1 approved these changes
+1 more reviewer
Dorin-David Dorin-David requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL