FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#1720 random-min-max 해답 번역 첫번째 줄 by kenna-hwa · Pull Request #1732 · javascript-tutorial/ko.javascript.info · GitHub

/ ko.javascript.info Public

#1720 random-min-max 해답 번역 첫번째 줄 - #1732

Open
kenna-hwa wants to merge 7 commits into
javascript-tutorial:masterfrom
kenna-hwa:1720-random-min-max-solution-1
ConversationCommits (7)ChecksFiles changed
Open

#1720 random-min-max 해답 번역 첫번째 줄#1732
kenna-hwa wants to merge 7 commits into
javascript-tutorial:masterfrom
kenna-hwa:1720-random-min-max-solution-1

Conversation

kenna-hwa commented Dec 1, 2023 •
edited
Loading

Copy link
Copy Markdown

요약

[신규 번역]

숫자형 과제 번역 (random-min-max 과제 해설의 첫번째 줄)

연관 이슈

#1720

Pull Request 체크리스트

TODO

  • 번역 규칙을 확인하셨나요?
    • 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
    • 맞춤법 검사기로 맞춤법을 확인하셨나요?
    • 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
  • 로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
  • PR 하나엔 번역문 하나만 넣으셨나요?
  • 의미 있는 커밋 메시지를 작성하셨나요?
    • 예시
      • [프락시] 번역
      • [프락시] 과제 번역
      • [if문과 조건부 연산자 '?'] 리뷰
      • [주석] 2차 리뷰
      • [Date 객체와 날짜] 번역

javascript-translate-bot requested a review from a team December 1, 2023 07:25

CLAassistant commented Dec 1, 2023 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

Violet-Bora-Lee reviewed Dec 1, 2023
View reviewed changes
Comment thread 1-js/05-data-types/02-number/8-random-min-max/solution.md Outdated
@@ -1,4 +1,4 @@
We need to "map" all values from the interval 0..1 into values from `min` to `max`.
우리는 0부터 1까지의 모든 값을 `최소값`부터 `최대값`까지의 "매핑"해야합니다.

Violet-Bora-Lee Dec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
우리는 0부터 1까지의 모든 값을 `최소값`부터 `최대값`까지의 "매핑"해야합니다.
우리는 0부터 1까지의 모든 값을 `min`부터 `max`까지의 범위로 '매핑' 해야합니다.

Violet-Bora-Lee Dec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/javascript-tutorial/ko.javascript.info/wiki/%EB%B2%88%EC%97%AD-%EB%AA%A8%EB%B2%94-%EC%82%AC%EB%A1%80

기여 가이드를 읽고 진행해주세요.

Violet-Bora-Lee requested changes Dec 1, 2023
View reviewed changes
Comment thread 1-js/05-data-types/02-number/8-random-min-max/solution.md Outdated
@@ -1,4 +1,4 @@
We need to "map" all values from the interval 0..1 into values from `min` to `max`.
우리는 0부터 1까지의 모든 값을 `최소값`부터 `최대값`까지의 "매핑"해야합니다.

Violet-Bora-Lee Dec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/javascript-tutorial/ko.javascript.info/wiki/%EB%B2%88%EC%97%AD-%EB%AA%A8%EB%B2%94-%EC%82%AC%EB%A1%80

기여 가이드를 읽고 진행해주세요.

javascript-translate-bot commented Dec 1, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

kenna-hwa commented Dec 3, 2023

Copy link
Copy Markdown
Author

/done

javascript-translate-bot requested a review from a team December 3, 2023 09:18
Violet-Bora-Lee requested changes Dec 6, 2023
View reviewed changes

Violet-Bora-Lee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

PR에 본인이 작성하지 않은 커밋들이 들어가있습니다.
작업 브랜치를 적절히 갱신해주세요.

javascript-translate-bot commented Dec 6, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Violet-Bora-Lee Violet-Bora-Lee requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL