FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Loops: while and for by andreimuntean1 · Pull Request #171 · javascript-tutorial/ro.javascript.info · GitHub

/ ro.javascript.info Public

Loops: while and for - #171

Open
andreimuntean1 wants to merge 9 commits into
javascript-tutorial:masterfrom
andreimuntean1:while-for
ConversationCommits (9)ChecksFiles changed
Open

Loops: while and for#171
andreimuntean1 wants to merge 9 commits into
javascript-tutorial:masterfrom
andreimuntean1:while-for

Conversation

andreimuntean1 commented Jan 23, 2023

Copy link
Copy Markdown

No description provided.

andreimuntean1 and others added 8 commits January 23, 2023 13:57
Translated article.md
9da651d
Translated solution.md
1afb63a
Translated task.md
a70f72a
Translate article.md
d8f4e09
Translated tasks
4a59e05
Revert "Translated task.md"
7ef3d55 
This reverts that commit to be able to make a PR with only the translation regarding loops.
Revert "Translated solution.md"
c572b8c 
This reverts that commit to be able to make a PR with only the translation regarding loops.
Revert "Translated article.md"
4b7f043 
This reverts that commit to be able to make a PR with only the translation regarding loops.
javascript-translate-bot requested a review from a team January 23, 2023 16:24
javascript-translate-bot mentioned this pull request Jan 23, 2023
Open
bogdanbacosca requested changes Jan 23, 2023
View reviewed changes

bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Codul trebuie revizuit pentru formatare corectă. Atenție deosebită la spații, linii și variabile.

Comment thread 1-js/02-first-steps/13-while-for/article.md Outdated
De exemplu, bucla de mai jos afișează `i` cât timp `i < 3`:

```js run
```js

bogdanbacosca Jan 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
```js
```js run

formatare, te rog sa faci la fel pentru fiecare instanță
Dacă apeși ctrl + D după ce ai evidențiat textul... apoi poți șterge și scrie toate erorile de-odată.

javascript-translate-bot commented Jan 23, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

andreimuntean1 commented Jan 23, 2023

Copy link
Copy Markdown
Author

/done

javascript-translate-bot requested a review from a team January 23, 2023 22:43
bogdanbacosca requested changes Jan 24, 2023
View reviewed changes

bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Trebuie verificare liniile: să nu fie linii șterse sau adăugate.
Trebuie verificat ca formatarea să coincidă cu originalul. (în setări la VSCode trebuie să dezactivezi formatarea automată)

Comment thread 1-js/02-first-steps/13-while-for/2-which-value-while/solution.md
```
Prima valoare este `i = 1` pentru că `++i` incrementează prima dată `i` și apoi returnează noua valoare. Așadar prima comparație este `1 < 5` și funcția `alert` afișează `1`.
2. **De la 1 la 5**

bogdanbacosca Jan 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

spațiile dintre linii trebuie lăsate cum sunt, altfel nu se văd bine diferențele dintre texte. vezi git diff

Comment thread 1-js/02-first-steps/13-while-for/2-which-value-while/task.md
1. The prefix form `++i`:
1. Forma cu prefix `++i`:

```js

bogdanbacosca Jan 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

formatare

Comment thread 1-js/02-first-steps/13-while-for/3-which-value-for/task.md
1. The postfix form:
1. Forma cu sufix:

```js

bogdanbacosca Jan 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

formatare

Comment thread 1-js/02-first-steps/13-while-for/4-for-even/solution.md
@@ -1,5 +1,3 @@

bogdanbacosca Jan 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

linii șterse

javascript-translate-bot commented Jan 24, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bogdanbacosca bogdanbacosca requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL