FIX Issue with Retrieving Columns Named with Colon ':' in Single Selection Using danfojs-node - #678
Open
junduck wants to merge 1 commit into
Open
FIX Issue with Retrieving Columns Named with Colon ':' in Single Selection Using danfojs-node#678junduck wants to merge 1 commit into
junduck wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…ction Using danfojs-node Fixes javascriptdata#639 by checking literal match first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #639 by checking literal match first.
When only one column passed as filter, this implementation checks if any exact match of columnNames before splitting and parsing as column range.
Test case also provided and verified this fix works as intended and non-breaking.