FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP Deprecate magic method. by KostyaSha · Pull Request #149 · jenkinsci/github-plugin · GitHub

WIP Deprecate magic method. - #149

Open
KostyaSha wants to merge 302 commits into
jenkinsci:masterfrom
KostyaSha:deprecate
Open

WIP Deprecate magic method.#149
KostyaSha wants to merge 302 commits into
jenkinsci:masterfrom
KostyaSha:deprecate

Conversation

KostyaSha commented Oct 17, 2016
edited
Loading

Copy link
Copy Markdown
Member

Relying on this manageHooks may end to situation that it will try register hook for GH server that has disabled hooks.

PS One line fluent is hardly readable for eyes.


This change is

MerkushevKirill and others added 30 commits July 15, 2015 22:45
caused by self-test validation for custom hook url
fix "Unknown content type null" in logs and since for 1.12.0 api
[JENKINS-29787] Fix NPE for race condition(?).
- with credentials usage
- with migrator from old gh-push-trigger descriptor config options to new gh-plugin
- with bean class to store deprecated creds (used only for migration)
+ reformat some code
+ add getters for fields
cleanup all gh-push-trigger descriptor related lines
- for migration process
- for changes in hooks
- for configuration logic
- change dontManageHooks=false to manageHooks=true
lanwen-ci and others added 26 commits July 24, 2016 14:42
also don't bother signature validation if no header from github with signature
[JENKINS-33974] Payload verification using shared secrets
[JENKINS-37481] Ignore sign header if sign not defined in Jenkins
* [FIXED JENKINS-38347] Use Initializer levels.

- migrator: Don't throw NPE because Descriptor wasn't ready.
- aliases: user annotation initializer.

* Ensure execution order.

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>

* Move to javadoc
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
}

/**
* @deprecated get GitHubServerConfig matching to exact remote GH server, filter and only then check allowToManage

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this method exists only to check - can we ever manage hooks somewhere

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But it useless.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nope, we can skip some actions if no any server is allowed to manage hooks (such as cleanup)

lanwen commented Nov 14, 2016

Copy link
Copy Markdown
Member

should be notice, not deprecation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL