FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[JENKINS-49332] Better error messages by carlossg · Pull Request #225 · jenkinsci/github-plugin · GitHub

/ github-plugin Public

[JENKINS-49332] Better error messages - #225

Merged
KostyaSha merged 6 commits into
jenkinsci:masterfrom
carlossg:JENKINS-49332
Jun 18, 2020
ConversationCommits (6)ChecksFiles changed
Merged

[JENKINS-49332] Better error messages#225
KostyaSha merged 6 commits into
jenkinsci:masterfrom
carlossg:JENKINS-49332

Conversation

carlossg commented Feb 10, 2020 •
edited by KostyaSha
Loading

Copy link
Copy Markdown
Contributor

when github repo webhook can't be created

Don't throw exceptions as we are handling the error, just print to the log

This change is 

[JENKINS-49332] Better error messages
6c63c10 
when github repo webhook can't be created

Don't throw exceptions as we are handling the error, just print to the log
jglick mentioned this pull request Apr 24, 2020
Draft
jglick reviewed May 11, 2020
View reviewed changes

jglick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This would really be useful, as I get these stack traces all the time. Would a cleaned-up version of this PR be welcome @KostyaSha?

Comment thread src/main/java/org/jenkinsci/plugins/github/webhook/WebhookManager.java Outdated

import com.cloudbees.jenkins.GitHubRepositoryName;
import com.google.common.base.Function;
import com.google.common.base.Optional;

jglick May 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems to be a compilation error.

KostyaSha commented May 12, 2020

Copy link
Copy Markdown
Member

This would really be useful, as I get these stack traces all the time. Would a cleaned-up version of this PR be welcome @KostyaSha?

I were waiting user to fixup #226 but any working variant will be ok

carlossg commented May 12, 2020

Copy link
Copy Markdown
Contributor Author

I think I forgot to come back to finish this.
It should work now, with the fixed tests

carlossg closed this May 12, 2020
carlossg reopened this May 12, 2020

carlossg commented May 12, 2020

Copy link
Copy Markdown
Contributor Author

CI failing with not enough space on disk

jglick commented May 12, 2020

Copy link
Copy Markdown
Member

I were waiting user to fixup #226

Ah, even better to not have to show an error at all because we never try to do something we are not permitted to do.

[JENKINS-49332] Do not register a problem
248b4f9 
if we don't have admin permissions

carlossg commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

I've changed it to not show the problem if there are no permissions, lowered the log level to debug and added more testing

jimklimov commented May 13, 2020

Copy link
Copy Markdown

About #226 - sorry I fell out of the loop, hope to get back to that soon. Or feel free to follow up with PRing wanted cleanups on top of that :)

psalaberria002 commented May 22, 2020

Copy link
Copy Markdown

Can this one be merged? We have hundreds of repos adding the stacktrace to the log. It would be very nice to get that fixed.

KostyaSha commented Jun 7, 2020

Copy link
Copy Markdown
Member

@carlossg @jglick is it done?

KostyaSha requested a review from jglick June 8, 2020 13:51
jglick approved these changes Jun 8, 2020
View reviewed changes

jglick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks fine. Have not tested it.

carlossg commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

yes it is done

KostyaSha merged commit 0c663b9 into jenkinsci:master Jun 18, 2020
jimklimov mentioned this pull request Nov 22, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jglick jglick approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL