Minor document update with clear images - #247
Conversation
Sorry, something went wrong.
jimklimov
left a comment
There was a problem hiding this comment.
Useful update of the docs, especially now that login/pass based stuff does not work :)
Sorry, something went wrong.
| @@ -85,7 +85,8 @@ Login and Password to token** | |||
| > credentials. | |||
|
|
|||
There was a problem hiding this comment.
By trial and error I found that the "Secret text" token, at least for a public github.com account, should contain just the token value ("ghp_Vari0usChars"); the "Test Connection" button helps see if that works. It seems that github knows the user name from that token alone.
I did not uncover what "in corresponding domain" here means in practice, and "Credentials are filtered on changing custom GitHub URL" in help text. My credential ID and description deliberately did not mention neither the account name nor github.com, and it still worked for the default https://api.github.com URL.
This would be nice to clarify in the doc and help, while we are at it.
Sorry, something went wrong.
There was a problem hiding this comment.
Adding some some text and screen shorts would be nice, I think.
Sorry, something went wrong.
oleg-nenashev
left a comment
There was a problem hiding this comment.
Would be nice to retain the original image file names. Anyway, it is a nice improvement, thanks!
Sorry, something went wrong.
@oleg-nenashev Can I replace the old files? OR old name with suffix? |
Sorry, something went wrong.
Signed-off-by: Bala Raman <srbala@gmail.com>
Document contains images not visible to read so, added new images. On step 3, check label change over the time, fix the label
This change is