[JENKINS-66079] Allow setting hookUrl from the global configuration page - #376
Open
franknarf8 wants to merge 2 commits into
Open
[JENKINS-66079] Allow setting hookUrl from the global configuration page#376franknarf8 wants to merge 2 commits into
franknarf8 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 2 commits
April 5, 2024 16:21
- Broken since 2019 : 4be509e - The hookUrl setter is not recognized by the bindJSON code since the input parameter type change from URL to String The following test crashes with the previous code : ``` @test public void hookUrlShouldHaveAWriteMethod() throws Throwable { PropertyDescriptor hookUrlWrite = PropertyUtils.getPropertyDescriptor( new GitHubPluginConfig(new ArrayList<>()), "hookUrl" ); assertNotNull("hookUrl write method should exits", hookUrlWrite.getWriteMethod()); } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes JENKINS-66079.
It is actually not possible to set hookUrl from the global config page since 2019. The hookUrl setter is not recognized by the bindJSON code since the input parameter type change from URL to String.
The following test crashes with the code prior to my changes :
@Test public void hookUrlShouldHaveAWriteMethod() throws Throwable { PropertyDescriptor hookUrlWrite = PropertyUtils.getPropertyDescriptor( new GitHubPluginConfig(new ArrayList<>()), "hookUrl" ); assertNotNull("hookUrl write method should exits", hookUrlWrite.getWriteMethod()); }Testing done
Re-enabled and modernized the test suite regarding global configs.
This change is