JENKINS-76080 - Validate signatures fix when secrets are not set - #441
Draft
HybridProgrammer wants to merge 5 commits into
Draft
JENKINS-76080 - Validate signatures fix when secrets are not set#441HybridProgrammer wants to merge 5 commits into
HybridProgrammer wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Update from upstream
…to be a probem but instead bad config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created tests with @Issue("JENKINS-76080") annotation to better understand the behavior described by users. I was able to recreate the issue when a shared secret config was created in jenkins but no share secret jenkins credential was created or selected. When the payload is sent to /github-webhook/ endpoint without Github's X-Hub-Signature headers the HTTP 400 error is returned.
Testing done
Submitter checklist
This change is