fix: make sure isort skips over files listed as such in the pyproject.toml tool configuration - #968
Merged
jenstroeger merged 1 commit intoSep 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
….toml tool configuration
behnazh
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thing is, we invoke isort via the pre-commit git hooks and that hook passes a list of files to isort in the command line. We now have to tell isort to filter those files by the settings in the configuration or else all files will be sorted. For details see the Filter files section in the isort docs.