| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Agent-Logs-Url: https://github.com/jetstack/version-checker/sessions/f773d382-07fb-40b4-8c53-eec3cb652854 Co-authored-by: davidcollom <1504448+davidcollom@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jetstack/version-checker/sessions/f773d382-07fb-40b4-8c53-eec3cb652854 Co-authored-by: davidcollom <1504448+davidcollom@users.noreply.github.com>
There was a problem hiding this comment.
This PR addresses unbounded Prometheus series growth by pruning stale per-container “current state” gauge series when the observed image/version for a container changes, keeping metric cardinality bounded for long-lived clusters.
Changes:
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/metrics/metrics.go | Prunes existing per-container gauge series prior to writing updated “current state” metrics to prevent series buildup. |
| pkg/metrics/metrics_test.go | Adds a regression test asserting stale version-labeled gauge series are removed after updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
| func TestAddImageReplacesExistingVersionMetrics(t *testing.T) { | ||
| reg := prometheus.NewRegistry() | ||
| m := New(logrus.NewEntry(logrus.New()), reg, fakek8s) | ||
|
|
||
| m.AddImage("namespace", "pod", "container", "container", "url", false, "1.0.0", "1.1.0") | ||
| m.AddImage("namespace", "pod", "container", "container", "url", true, "1.1.0", "1.1.0") | ||
|
|
||
| assert.Equal(t, 1, | ||
| testutil.CollectAndCount(m.containerImageVersion.MetricVec, MetricNamespace+"_is_latest_version"), | ||
| ) | ||
| assert.Equal(t, 1, | ||
| testutil.CollectAndCount(m.containerImageChecked.MetricVec, MetricNamespace+"_last_checked"), | ||
| ) |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
version-checker was retaining superseded version_checker_is_latest_version series for active containers. In clusters that run long enough and observe image/version churn, this causes Prometheus label cardinality to grow over time and can present as steady memory growth/OOMs.
Root cause
Change
Result
Regression coverage