build(desktop): fix Windows asar paths and Rosetta timeout in publish checks - #2017
Open
paustint wants to merge 1 commit into
Open
build(desktop): fix Windows asar paths and Rosetta timeout in publish checks#2017paustint wants to merge 1 commit into
paustint wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… checks The desktop-v4.13.0 publish failed on both platforms on the first real run of the new afterPack checks, with no actual packaging defect. On Windows the closure verifier passed posix-style paths to asar.extractFile, which splits archive lookups on path.sep, so the very first dependency read appeared missing. On macOS the x64 smoke test runs under Rosetta 2 on the arm64 runner, and first-launch binary translation ate ~80s of the 90s budget; the launch timeout is now 300s (real post-boot hangs are still caught by the in-app 30s renderer timer). Also drops NODE_OPTIONS from the smoke-test env to silence Electron's startup error about the disabled fuse. Closes #2012 Closes #2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop-v4.13.0 publish failed on both platforms on the first real run of the new afterPack checks, with no actual packaging defect. On Windows the closure verifier passed posix-style paths to asar.extractFile, which splits archive lookups on path.sep, so the very first dependency read appeared missing. On macOS the x64 smoke test runs under Rosetta 2 on the arm64 runner, and first-launch binary translation ate ~80s of the 90s budget; the launch timeout is now 300s (real post-boot hangs are still caught by the in-app 30s renderer timer). Also drops NODE_OPTIONS from the smoke-test env to silence Electron's startup error about the disabled fuse.
Closes #2012 Closes #2013