FIX decode error when image is bottom up - #30
Open
francoisp wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yeah noticed that too, I have to merge the code in a lib for now and fiddle with webpack. I also fixed a small bug when orientation is bottom down: https://github.com/francoisp/bmp-ts. cheers. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks for the bottom-up fix work in this PR. In the maintained fork this area is covered and released, including bottom-up/top-down decode handling and fixture-backed tests:
Happy to help with a backportable patch if upstream maintenance resumes. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small bugfix, when a BMP image is bottom out of jimp getBufferAsync, the height is a negative value. Also added function exports, and BTW the npm package for 1.0.4 is broken