Allow files with CR newline - #43
molsonkiko wants to merge 3 commits into
Conversation
Sorry, something went wrong.
tweak query window UI remove dinging when Enter or Tab pressed in query window.
|
I tried running CsvQuery on NPP 7.3.3 64bit and this plugin made Notepad++ crash. This doesn't happen on NPP 7.3.3 32bit. |
Sorry, something went wrong.
|
NPP did some changes to the x64 internal workings in 8.3, so a plugin released after that (1.2.9) will not work with a N++ version before 8.3. If you HAVE to use a v7 of N++, you have to use an old version of CsvQuery as well, i.e. v1.2.8 or older. |
Sorry, something went wrong.
|
Thanks for the tip about older versions. I just keep a lot of NPP versions installed on my computer for testing. If you wanted the minimum viable fix for this bug, I would just apply my simple changes to CsvSettings.cs and keep my new test and my new test file. |
Sorry, something went wrong.
|
I'll take a look as soon as possible (this is a hobby project)! Thanks for
the PR!
…On Tue, 14 Mar 2023 at 15:18, molsonkiko ***@***.***> wrote:
Thanks for the tip about older versions. I just keep a lot of NPP versions
installed on my computer for testing.
If you wanted the minimum viable fix for this bug, I would just apply my
simple changes to CsvSettings.cs
<3ec3756#diff-8cf81cf3fa608e27b47580f2da35d8fe1ea5521191e6cf0a2695c957c1dcdc72>
and keep my new test
<3ec3756#diff-80a6e10777f7ad218b48078fede57a76bfef338553b6f8e081903dfbffe902f6>
and my new test file
<3ec3756#diff-7e8db74b353fcb9a691d905ae313a5fa8a9593f8d60b2d4b1f3266cb9cb6d223>
.
—
Reply to this email directly, view it on GitHub
<#43 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRR3GLDJJCZTS6IEXJ7RDW4B44BANCNFSM6AAAAAAVZWHXTI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sorry, something went wrong.
Previously files with CRLF and LF newlines were supported, but not CR. Address #41 .
Added a test for this.
Also fixed an annoying UI problem with the query form where hitting enter or tab would cause a dinging noise.
I ran tests on my computer and the only tests that failed were the MSSQL tests (which is expected because SQL Server is not installed on my computer).