@Iamrodos thoughts on unit tests here?

@Iamrodos thoughts on unit tests here?

I wrote one yesterday but ended up abandoning the post.

1. It was about ninety lines of testing for a one line code change. It was more about regression testing over efficacy.
2. There is a rabbit hole I went down over removing the crash which starts masking failed runs. The earlier test of 128 fires for a DMCA but also for network error, throttle etc. I got lost trying to untangle that and if warnings should be present, because the clone is skipped but the metadata retrieved earlier is still saved.

Net outcome, the change is valid and a test is probably border line helpful. The nuances around failures get so convoluted with the shell command and error codes that it's probably best to wait for issues than over engineer (which is my typical tendency 😊 ).