FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Symbol table tweaks by headius · Pull Request #8907 · jruby/jruby · GitHub

/ jruby Public

Symbol table tweaks - #8907

Merged
headius merged 1 commit into
jruby:masterfrom
headius:symbol_table_tweaks
Jul 10, 2025
Merged

Symbol table tweaks#8907
headius merged 1 commit into
jruby:masterfrom
headius:symbol_table_tweaks

Conversation

headius commented Jul 10, 2025

Copy link
Copy Markdown
Member

A few small tweaks to the symbol table.

headius added this to the JRuby 10.0.1.0 milestone Jul 10, 2025

headius commented Jul 10, 2025

Copy link
Copy Markdown
Member Author

These were discovered while attempting to get test_marshal_with_ruby2_keywords_hash passing, since it depends on comparing an incoming UTF-7 "K" symbol with the default US-ASCII version already in the table. Fixing the reset ordering resolved an issue finding the existing symbol (it was being created and then wiped out) but because we key our symbol table off the hash of the raw bytes without the encoding, we can't ultimately distinguish between these otherwise identical symbols. There's no way to pass the test with the symbol table not considering encoding at this point (see some explanation of that limitation at #6341 (comment)).

* Make compoundSymbolTable final.
* Inline load factor, since it's not configurable anyway.
* Reset table in constructor before creating special symbols.
headius force-pushed the symbol_table_tweaks branch from 01eb5cc to 259ddf3 Compare July 10, 2025 15:38
headius merged commit 25dc482 into jruby:master Jul 10, 2025
headius deleted the symbol_table_tweaks branch July 10, 2025 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL