Update Hash#inspect logic for multibyte keys - #8908
Merged
headius merged 2 commits intoJul 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Symbol inspect was updated some time ago to avoid escaping multi- byte characters that do not interfere with emitting a value literal symbol, but our Hash#inspect logic did not get the same updates. As a result it continued to escape all but the most trivial symbol keys, leading to issues like jruby#8783. This updates the relevant logic based on the C implementation. Fixes jruby#8783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update logic from the C impl for inspecting a Hash with symbol keys that are valid multibyte literal symbol characters.
Fixes #8783.