Handle argument or block passed to Range#count - #8956
Merged
headius merged 2 commits intoAug 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Block-receiving Range#count should always use Enumerable logic. Also add single-arg form which falls back on Enumerable. Fixes jruby#8955
These specs are lightly-modified versions of the same specs from Enumerable#count, but those specs depend on the Enumerable having multiple of the same value. A shared spec could probably be pulled out. See jruby#8955.
pboling
reviewed
Aug 10, 2025
pboling
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic installed to prevent large ranges from manually iterating to calculate a count (79ee920) short-circuited the fallback on Enumerable#count logic. That broke count when passed a block (as described in #8955). Additionally, we did not handle the case where Range#count is passed an argument.
This PR fixes both cases and adds specs.