Fix memory leak in Concurrent/ThreadSafeLocalContextProvider - #8969
Merged
headius merged 4 commits intoAug 20, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Uses the Cleaner API to run LocalContext.remove() when a Thread has terminated, but also eagerly calls all LocalContext.remove() on terminate().
Cleaner is Java 9+, so it cannot be used on JRuby 9 because that is meant to run on Java 8 and up. The disadvantage wrt the Cleaner API is that this will leak a Thread if `terminate()` is never called. At least it's a Daemon Thread so it doesn't keep the JVM from exiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-push of #8483