glob refactoring - #8984
Merged
enebo merged 19 commits intoSep 4, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The buf reuse was confusing to follow and generally was always making a new buf anyways.
consolidate common createPath to top of loop. favor else over continue
headius
requested changes
Sep 4, 2025
headius
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Minor changes but looks good.
Sorry, something went wrong.
Comment thread
core/src/main/java/org/jruby/api/Convert.java
Outdated
Comment thread
core/src/main/java/org/jruby/util/Dir.java
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.