Ignore encoding when unmarshaling an Encoding - #9051
Merged
headius merged 1 commit intoOct 31, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
CRuby appears to marshal all Encoding objects with a special encoding instance variable indicating they have an encoding of US-ASCII, even though Encoding does not actually have an encoding. I've filed an issue about this for clarification below, but for now we ignore this peculiar situation. https://bugs.ruby-lang.org/issues/21658 Fixes jruby#9050
This was referenced Oct 31, 2025
Copy link
Copy Markdown
Member
Author
|
Checked into TruffleRuby impl and they basically ignore encoding instance vars for object types that don't have encoding. CRuby rejects such classes outright, but has an exception for T_DATA that is an encoding object, so basically what we have here. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRuby appears to marshal all Encoding objects with a special encoding instance variable indicating they have an encoding of US-ASCII, even though Encoding does not actually have an encoding. I've filed an issue about this for clarification below, but for now we ignore this peculiar situation.
https://bugs.ruby-lang.org/issues/21658
Fixes #9050