FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update specs by eregon · Pull Request #9193 · jruby/jruby · GitHub

/ jruby Public

Update specs - #9193

Merged
eregon merged 3 commits into
jruby:masterfrom
eregon:update-specs
Jan 28, 2026
Merged

Update specs#9193
eregon merged 3 commits into
jruby:masterfrom
eregon:update-specs

Conversation

eregon commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

eregon added this to the Non-Release milestone Jan 28, 2026

eregon commented Jan 28, 2026
edited
Loading

Copy link
Copy Markdown
Contributor Author

@headius How about enabling Allow auto-merge in the Settings + some required CI checks (in branch protection)?
Then PRs like this one could auto-merge automatically as soon as they pass the required CI checks.
Not a big problem, but would be nice and both CRuby and TruffleRuby use that currently.

eregon merged commit 27ff6be into jruby:master Jan 28, 2026
76 checks passed
eregon deleted the update-specs branch January 28, 2026 22:09

headius commented Jan 29, 2026

Copy link
Copy Markdown
Member

@eregon I can discuss it with @enebo and maybe we will enable it. I'm reluctant to make any merge automatic because it could result in incomplete work getting merged (if no guards) or require a third-party review or other conditions (which would prevent me merging my own PRs). Perhaps you can explain how you have it set up for TR?

Thanks for the spec update!

headius commented Jan 29, 2026

Copy link
Copy Markdown
Member

I've made the following config changes:

  • Require passing status checks
  • Require PR
  • Require one approval
  • Require branch to be up to date

But disabled:

  • Do not allow these rules to be bypassed

I think that will enable auto-merging without limiting us from manually merging our own branches and PRs.

eregon commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

I'm reluctant to make any merge automatic because it could result in incomplete work getting merged (if no guards) or require a third-party review or other conditions (which would prevent me merging my own PRs).

It still requires someone with write access to the repository to enable auto merge, that remains a manual step.

Perhaps you can explain how you have it set up for TR?

I have Allow auto-merge and only Require a pull request before merging & Require status checks to pass before merging.
That way maintainers/people with Write access can still merge their own PR.

I would recommend against Require branch to be up to date because that's just annoying and doesn't really gain anything (when the change is merged it will be up-to-date, no point to rerun CI N times just because N pushes to master in between). If contributors use the UI for that it will create an extra merge commit which is unnecessary noise.

Require one approval might mean I wouldn't be able to merge PRs like this one I think, but the bypass seems to cancel that requirement because when I look e.g. at #9109 I do see a green merge button.

So looks OK but would recommend to remove Require branch to be up to date to avoid lots of extra CI runs and extra merge commits.

eregon mentioned this pull request Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL